Skip to content

Commit

Permalink
fix: minor compiling errors since Emulsify Core was merged into paren…
Browse files Browse the repository at this point in the history
…t branch
  • Loading branch information
Callin Mullaney committed Sep 10, 2024
1 parent 030d586 commit d6dd66c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
4 changes: 3 additions & 1 deletion src/components/banner/_banner.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use '../../foundation/typography/typography' as *;

.banner {
min-height: 16rem;
position: relative;
Expand Down Expand Up @@ -73,7 +75,7 @@
padding: var(--spacing-2xl) var(--spacing-xl);

.heading {
@include heading-large;
@include h2;

margin: 0 0 calc(var(--spacing-lg) * 1.5);
}
Expand Down
4 changes: 2 additions & 2 deletions src/components/banner/banner.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Drupal.behaviors.banners = {
*
* @description Returns references to banner elements.
* @param {HTMLElement} banner Banner element.
* @returns {Object} References to label, button, video, pause, and play elements.
* @return {Object} References to label, button, video, pause, and play elements.
*/
function getBannerReferences(banner) {
return {
Expand All @@ -24,7 +24,7 @@ Drupal.behaviors.banners = {
*
* @description Starts video playback and updates UI to reflect the playing state.
* @param {Object} refs Object containing element references.
* @returns {Promise} Resolves when the video starts playing or rejects with an error.
* @return {Promise} Resolves when the video starts playing or rejects with an error.
*/
function playVideo(refs) {
return new Promise((resolve, reject) => {
Expand Down
4 changes: 2 additions & 2 deletions src/components/banner/banner.stories.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import bannerTwig from './banner.twig';
import { props } from './banner.component.yml';
import bannerVideo from '../../media/video-placeholder.mp4';
import bannerImage from '../../images/example/banner-image.jpg';
import bannerVideo from '../../../assets/audio/video-placeholder.mp4';
import bannerImage from '../../../assets/images/example/banner-image.jpg';
import './banner';

export default {
Expand Down
2 changes: 1 addition & 1 deletion src/components/banner/banner.twig
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
{# Render the main content #}
<div {{ bem('content', [banner__alignment], banner__base_class) }}>
{% if banner__title %}
{% include "@components/text/headings/_heading.twig" with {
{% include "@components/text/headings/heading.twig" with {
heading__level: banner__heading__level|default('4'),
heading: banner__title,
} %}
Expand Down

0 comments on commit d6dd66c

Please sign in to comment.