Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min / max values on top of customization screen #686

Closed
tp1de opened this issue Oct 16, 2022 · 9 comments
Closed

Add min / max values on top of customization screen #686

tp1de opened this issue Oct 16, 2022 · 9 comments
Labels
enhancement New feature or request
Milestone

Comments

@tp1de
Copy link
Contributor

tp1de commented Oct 16, 2022

Min / Max values can be changed / added to entities by using the customization screen. This is done by entering within pop-up window.
It's not where convenient to have no overview about entered (or original) min max values.

Let me recommend to add the 2 fields for min / max on the overview screen of customization settings.

@tp1de tp1de added the enhancement New feature or request label Oct 16, 2022
@proddy
Copy link
Contributor

proddy commented Oct 16, 2022

We knew of these trade-offs when the first version of adding min & max was implemented. I agree it would make sense at some point to fetch the default min/max from the server and show the range in the Value column for numeric values, like "22.5 (5/30)" and also populate the pop-up window.

@MichaelDvP
Copy link
Contributor

MichaelDvP commented Oct 17, 2022

The empty popup was intended to show if customization is set, but can be changed to show actual min/max.
The default values are not stored in memory to save ram, we can only show the acual used min/max values.
I think min/max columns are better than brackets and value should be last right.

BTW: The popup should not use a SAVE-Button to avoid misunderstanding. it is only set in browser and transfered/saved with the SAVE-Button of customization page. Name the popup button UPDATE (already translated), or SET (needs translation).

@tp1de
Copy link
Contributor Author

tp1de commented Oct 17, 2022

The user interface for customization is not very convenient to adjust multiple values. Whenever a popup showed up the customization screen returns to original screen (starting with line 1). With multiple pages like for me, it's not very convenient to scroll down after each change. And for min/max values it's difficult to get the overview of changes since it's not on the overview screen of customizations - just within the json-file. That's why I thought it might be good to see the min/max values on the first screen.

Nevertheless it's a nice feature to get the min/max changes within seconds updated in HA.

@proddy
Copy link
Contributor

proddy commented Oct 17, 2022

I agree @tp1de . There's still plenty of work to do.

@MichaelDvP instead of adding a Min and Max column to the table, which really is only useful for numeric values that are writeable, we could instead just add a single column called 'Parameters' that for example show the type and range, e.g.
'text'
'enum'
'number 5-30'
'boolean'

?

@tp1de
Copy link
Contributor Author

tp1de commented Oct 17, 2022

I think it's not priority. Any chance that returning from pop-up window the cursor stays on selected line?

... and I am not sure if reasonable ranges - especially for temperatures - should not be (better) initialized within code?
... and I recognized that emptying the min/max fields do not change the values back to standard until system restart. Intended?

@MichaelDvP
Copy link
Contributor

It's for customization and this is done normally once. The json for all shortnames, longnames, customnames, mask and min max is very large. Blow it up with settings (bool, enum, etc) that can not be customized? I think this is not needed. Min max shows only for entities that have a command and are numbers. For other entities and those without value the min max is not shown. This looks like this:
grafik

I agree that best is to set the right min/max while registering, but we don't know the right values and they are different for different boilers and thermostats. (e.g. maxburnpower 100%, 135%, 165%).

@MichaelDvP
Copy link
Contributor

I've also tried with brackets in value field, but for my eyes the coulumns are better readable. (Except in smartphone portrait-mode)
grafik

@proddy proddy added this to the v3.5.0 milestone Oct 29, 2022
@tp1de
Copy link
Contributor Author

tp1de commented Oct 30, 2022

but for my eyes the columns are better readable.

@MichaelDvP I agree on the columns are better ... and if possible the cursor should return to the changed line when updating customizations.

@MichaelDvP
Copy link
Contributor

and if possible the cursor should return to the changed line when updating customizations.

I don't know how to do this the easy way (remember and restore scroll position).
I think @proddy knows better how to do it.

MichaelDvP added a commit to MichaelDvP/EMS-ESP32 that referenced this issue Oct 31, 2022
MichaelDvP added a commit to MichaelDvP/EMS-ESP32 that referenced this issue Oct 31, 2022
@proddy proddy closed this as completed Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants