-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min / max values on top of customization screen #686
Comments
We knew of these trade-offs when the first version of adding min & max was implemented. I agree it would make sense at some point to fetch the default min/max from the server and show the range in the Value column for numeric values, like "22.5 (5/30)" and also populate the pop-up window. |
The empty popup was intended to show if customization is set, but can be changed to show actual min/max. BTW: The popup should not use a SAVE-Button to avoid misunderstanding. it is only set in browser and transfered/saved with the SAVE-Button of customization page. Name the popup button UPDATE (already translated), or SET (needs translation). |
The user interface for customization is not very convenient to adjust multiple values. Whenever a popup showed up the customization screen returns to original screen (starting with line 1). With multiple pages like for me, it's not very convenient to scroll down after each change. And for min/max values it's difficult to get the overview of changes since it's not on the overview screen of customizations - just within the json-file. That's why I thought it might be good to see the min/max values on the first screen. Nevertheless it's a nice feature to get the min/max changes within seconds updated in HA. |
I agree @tp1de . There's still plenty of work to do. @MichaelDvP instead of adding a Min and Max column to the table, which really is only useful for numeric values that are writeable, we could instead just add a single column called 'Parameters' that for example show the type and range, e.g. ? |
I think it's not priority. Any chance that returning from pop-up window the cursor stays on selected line? ... and I am not sure if reasonable ranges - especially for temperatures - should not be (better) initialized within code? |
@MichaelDvP I agree on the columns are better ... and if possible the cursor should return to the changed line when updating customizations. |
I don't know how to do this the easy way (remember and restore scroll position). |
Min / Max values can be changed / added to entities by using the customization screen. This is done by entering within pop-up window.
It's not where convenient to have no overview about entered (or original) min max values.
Let me recommend to add the 2 fields for min / max on the overview screen of customization settings.
The text was updated successfully, but these errors were encountered: