Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set the duration trigger of a shower #1801

Closed
proddy opened this issue Jun 15, 2024 · 9 comments
Closed

set the duration trigger of a shower #1801

proddy opened this issue Jun 15, 2024 · 9 comments
Labels
enhancement New feature or request
Milestone
v3.7.0

Comments

@proddy
Copy link
Contributor

proddy commented Jun 15, 2024

Hi, is there any possibility in ESP config to set the duration trigger of a shower higher than 2min? Many thanks in advance...

Originally posted by @NongJoWo in #1293 (comment)
@proddy proddy added the enhancement New feature or request label Jun 15, 2024
@proddy proddy added this to the v3.7.0 milestone Jun 15, 2024
@proddy
Copy link
Contributor Author

proddy commented Jun 15, 2024

Todo: make SHOWER_MIN_DURATION a setting

proddy added a commit to proddy/EMS-ESP32 that referenced this issue Jun 19, 2024
@proddy
shower_min_duration emsesp#1801
20beda7
proddy added a commit that referenced this issue Jun 20, 2024
@proddy
Merge pull request #1807 from proddy/dev
19c93e2 
#1801 shower_duration_min
@proddy
Copy link
Contributor Author

proddy commented Jun 20, 2024

in dev14 - can you test @NongJoWo

@NongJoWo
Copy link

I don't have any experience with GitHub projects. How can I test it?

@proddy
Copy link
Contributor Author

proddy commented Jun 20, 2024

I don't have any experience with GitHub projects. How can I test it?

Download the latest dev release from https://github.com/emsesp/EMS-ESP32/releases/tag/latest, or use the EMS-ESP Web user interface to download this for you. It'll be version 3.7.0 so if you're coming from 3.6.x there will be a few surprises!

@NongJoWo
Copy link

OK, the update was really easy! I've adjusted the shower timer. Now I just have to take a shower. I'll let you know when everything is OK. Thanks for the super-fast support!!

@NongJoWo
Copy link

So just tested. The shower trigger works perfectly. Unfortunately, the shower duration no longer works. Only the value 0 is returned here. There is also a new MQTT-device: ems-esp Shower. However, this does not contain any entities.

@proddy
Copy link
Contributor Author

proddy commented Jun 23, 2024 •
edited
Loading

thanks for reporting. I porbably broke something. Will take a look and test soon

edit think its fixed now

proddy added a commit to proddy/EMS-ESP32 that referenced this issue Jun 23, 2024
@proddy
fix duration conversion from ms emsesp#1801
79e7842
@NongJoWo
Copy link

Should I download and test the new version?

@NongJoWo
Copy link

Just tested. Now everything is as expected. Many thanks again!

@proddy proddy closed this as completed Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.7.0
Development

No branches or pull requests
2 participants
@proddy @NongJoWo