Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow device name to be customized #1174

Closed
proddy opened this issue May 13, 2023 · 2 comments
Closed

Feature: Allow device name to be customized #1174

proddy opened this issue May 13, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@proddy
Copy link
Contributor

proddy commented May 13, 2023

          > A user wants to look at details from their device so the name is more important that the type

For users with multiple devices, like 3 mixers for hcs and dhw name and type are not clear. Maybe think about custom device names, or add, depending on device-id, the circuit to the name (e.g. "MM100 (hc1)"). But i think optional custom names are better.

Originally posted by @MichaelDvP in #1169 (comment)

@proddy proddy added the enhancement New feature or request label May 13, 2023
@proddy
Copy link
Contributor Author

proddy commented May 13, 2023

This feature is to extend the Settings->Customization page to allow the EMS Device Name to be renamed. I suggest adding a RENAME button to that page after a device is selected. And the name will be stored in the customizations masked_entities alongside the product_id and device_id which makes it easier and less code. If the custom name is empty ('') it will default to the one stored in Flash from device_library.

It sounds simple but there is some backend code to write.

@proddy proddy added this to the v3.7.0 milestone Aug 12, 2023
@proddy proddy removed this from the v3.7.0 milestone Dec 16, 2023
@proddy proddy added this to the v3.7.0 milestone Jun 25, 2024
@proddy
Copy link
Contributor Author

proddy commented Jun 25, 2024

As our DB is growing and we're seeing multiple brands and models using the same ProductID I think this is important to add as a next feature. I'll add a Rename option to the Customizations WebUI.

@proddy proddy self-assigned this Jun 25, 2024
@proddy proddy changed the title Allow device name to be customized Feature: Allow device name to be customized Jun 25, 2024
proddy added a commit to proddy/EMS-ESP32 that referenced this issue Jul 2, 2024
proddy added a commit to proddy/EMS-ESP32 that referenced this issue Jul 3, 2024
@proddy proddy closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant