Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

Dev #92

Closed
wants to merge 11 commits into from
Closed

Dev #92

wants to merge 11 commits into from

Conversation

lobocobra
Copy link

Hi Proddy

Many thanks for implementing my code. I learned alot by looking at your changes.
=> As some of the features did not work, I fixed them and this PR represents a working code, based on your changes.

lobocobra and others added 11 commits March 23, 2019 00:18
- save heatcircuit works
- mqtt raw send works

Not working
- no mqtt response on raw request
- no mqtt info back to mqtt server
- heatcircuit 2 not changable dynamically (probably fixed if activated as save is now working)
- save of HC works, but 0x47 0x48 still hard coded
- 5 new variables added and they are now loaded on read BUT no mqtt send so far
- raw send over mqtt works BUT without response

Missing features
- send per MQTT all values
- send response after mqtt raw

Errors
- still some errors missed read (not from my code)
- still -3200° when no in house temp
=> heatingcircuit still hard-coded, rest works pretty well
=> answer on raw data by mqtt not yet implemented
=> To be tested with someone that uses HC1.

Missing
- still missing mqtt response on mqtt-raw-send (send works, answer not implemented)
I merged and I fixed the errors, now it should work.
- open task, add new mqtt commands for day,night,holiday
- remove mqtt raw for others than me
- find a fix with 0x48 settemp beeing empty when auto switches from night to day.
=> and minimal value control for temperature
=> Fully working, Proddy overworked code of Lobo
# Conflicts:
#	src/ems-esp.cpp
#	src/ems.cpp
#	src/ems.h
#	src/ems_devices.h
#	src/my_config.h
#	src/version.h
@proddy
Copy link
Collaborator

proddy commented Apr 7, 2019

it's really hard to see the differences between the current dev branch and your PRs so I tried to add them manually.

@lobocobra
Copy link
Author

Sorry to hear, I tried to put //lobocobra, everywhere I changed some code.
=> let me test your latest version, in case I have some issues after I will find out, where are the differences

@lobocobra
Copy link
Author

Cool, now all except one tiny thing is working! Many thanks for that.

Last gap
Thermostat stats: Thermostat type: RC35 (ProductID:86 Version:21.04) Setpoint room temperature: ? C Current room temperature: ? C Day temperature: 22.5 C Night temperature: 19.0 C Vacation temperature: 16.0 C Thermostat time is 20:10:33 7/4/2019 Mode is set to auto

When you have a floor-heating then you will use the external temp and the "Current room temp sensor" is deactivated.
The firmware stops execution if one of both values are not valid, this leads to 2x "?"

To fix this quickly (accepting the second value to be at 0)
ems-esp.cpp line 623....
Original code:
if ((EMS_Thermostat.curr_roomTemp <= 0) || (EMS_Thermostat.setpoint_roomTemp <= 0))
Needed change:
if ((EMS_Thermostat.curr_roomTemp <= 0) && (EMS_Thermostat.setpoint_roomTemp <= 0))

But honestly this is even less than a minor issue! nobody is in the console the whole day long :)

@lobocobra
Copy link
Author

I close the PR as your inserted code fixes all remaining issues.
=> Many thanks for the effort you invested to integrate my code!

@lobocobra lobocobra closed this Apr 7, 2019
@proddy
Copy link
Collaborator

proddy commented Apr 7, 2019

no, thank you! You've been an enormous help and all your testing, patience and contributions keep this project alive.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants