-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Python 3.11 #303
Conversation
the python abi package is build after the python pkg, therefore it cannot find it a solution would be to either make a pr with just the abi package or explicitly add the abi package as dependency to the python recipe |
Thanks @DerThorsten.
I opened #306 |
Since we probably want to maintain also python3.10 it might make sense to have two recipes python3_10 and python3_11. https://github.com/emscripten-forge/recipes/blob/main/conda_build_config.yaml#L404 And cross-python itself will also need a bit of changes: (but we can probably prepare a lot of things by removing hard coded python versions) |
@@ -2,7 +2,7 @@ | |||
|
|||
cp $RECIPE_DIR/patches/configure . | |||
|
|||
PYTHON=${BUILD_PREFIX}/bin/python3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would revert the hard-coded changes and only change it in the python recipe but not all the other recipes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, is it because this should be tackled in #308 instead?
@jtpio you need to revert your changes where you changed 3.10 to 3.11. |
ok..you where faster than me typing^^ |
fyi the most recent error seems to be this..is a bit hidden
@jtpio I can also try to build this locally..this might be easier than via the CI |
Sure, thanks @DerThorsten. Feel free to push to the branch directly if you would like to. |
@DerThorsten curious if you were able to find more information about the error locally |
not yet, but its the next item on my stack...still stuck with some other emscripten-forge issue. |
alright no problem, thanks for your help! |
line 299 is:
Maybe some template replacement for @MODULE_BLOCK@ is not working. |
@jtpio I think we need to rewrite a lot of the we can essentially just do whatever pyodide is doing here: The config files are the here: In particular the Setup.local changed a lot https://github.com/pyodide/pyodide/blob/main/cpython/Setup.local |
Closing in favor of #643 |
Try updating to Python 3.11.
Probably need to align some fixes with Pyodide: pyodide/pyodide#3252