Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the logic for loading sub-scripts in the main script #52

Closed

Conversation

martinRenou
Copy link
Contributor

This allows to use that file directely in xeus-python kernel without having to run through a webpack config to process the file

This allows to use that file directely in xeus-python kernel without
having to run through a webpack config to process the file
@martinRenou
Copy link
Contributor Author

This makes it only runnable from a web worker though, what do you think @DerThorsten ?

@DerThorsten
Copy link
Collaborator

I would prefer a solution working also from the main thread.
What about we just generate a packages_to_load.json and do the actual importing in the applications?

Ie applications would need to fetch the json containing a list of all the pkgs they need to import, and they then do the appropriate importing by themself?

@martinRenou
Copy link
Contributor Author

That could be an idea.

I was also thinking of adding a new CLI (and Python) parameter --web-worker or something for generating this output. What would you think of this?

@DerThorsten
Copy link
Collaborator

What about we just generate a packages_to_load.json and do the actual importing in the applications?

jeah lets do that

@martinRenou
Copy link
Contributor Author

I kinda like the CLI option idea instead, as it makes the output of empack readily usable (instead of having to parse the packages_to_load.json JSON file and do the loading yourself).

@martinRenou
Copy link
Contributor Author

@DerThorsten thoughts?

@martinRenou
Copy link
Contributor Author

This is outdated and not needed anymore

@martinRenou martinRenou deleted the use_importscripts branch February 14, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants