Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bazel] Let audio workout bootstrap js file be generated. #1404

Merged
merged 2 commits into from
Jun 14, 2024
Merged

[Bazel] Let audio workout bootstrap js file be generated. #1404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13ba443
Allows generation of audio worklet bootstrap js file
Jun 11, 2024
8d68000
adds audio worklet js to wasm_cc_binary too
Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bazel/emscripten_toolchain/link_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@
'.data',
'.js.symbols',
'.wasm.debug.wasm',
'.html'
'.html',
'.aw.js'
]

for ext in extensions:
Expand Down
3 changes: 3 additions & 0 deletions bazel/emscripten_toolchain/wasm_cc_binary.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ _ALLOW_OUTPUT_EXTNAMES = [
".js.symbols",
".wasm.debug.wasm",
".html",
".aw.js",
]

_WASM_BINARY_COMMON_ATTRS = {
Expand Down Expand Up @@ -151,6 +152,7 @@ def _wasm_cc_binary_legacy_impl(ctx):
ctx.outputs.symbols,
ctx.outputs.dwarf,
ctx.outputs.html,
ctx.outputs.audio_worklet,
]

args = ctx.actions.args()
Expand Down Expand Up @@ -201,6 +203,7 @@ def _wasm_binary_legacy_outputs(name, cc_target):
"symbols": "{}/{}.js.symbols".format(name, basename),
"dwarf": "{}/{}.wasm.debug.wasm".format(name, basename),
"html": "{}/{}.html".format(name, basename),
"audio_worklet": "{}/{}.aw.js".format(name, basename)
}

return outputs
Expand Down