feat(docker): install npm dependencies of emscripten #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
changed the title
sbc100
reviewed
Apr 12, 2024
| @@ -50,6 +50,12 @@ RUN echo "## Aggressive optimization: Remove debug symbols" \ | |||
| && find ${EMSDK}/upstream/bin -type f -exec strip -s {} + || true \ | |||
| && echo "## Done" | |||
|
|
|||
| RUN echo "## Installing npm dependencies" \ | |||
There was a problem hiding this comment.
The emsdk build script uses does install npm dependencies, just no the devDependencies. It uses npm ci --production --no-optional.
How about emsdk install tsc so that we its more obvious why we are doing this here?
There was a problem hiding this comment.
Hm, in that case perhaps emscripten should move typescript to dependencies instead.
There was a problem hiding this comment.
We decided we didn't want to add the tsc dependency for all users, and instead make it an optional dependencies that certain users can opt into.
We can possibly revisit that decision at a later date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install the npm dependencies of emscripten during Docker build to support the
--emit-tsdflag by default.Closes #1370