Fix FileExistsError on subsequent bazel builds on Windows #1326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1181.
os.rename()
has different behaviors on Windows vs Linux, usingos.replace()
instead fixes theissue when a new build is created when previous files exist from an older build.
I'm not sure if this is the best way to do this though since there's the method
move_with_overwrite()
in emsdk.py which does whatos.replace()
is supposed to do. Regarding atomicity, according to python documentation,os.replace()
's renaming is atomic as a POSIX requirement, but Windows isn't fully POSIX compliant.emsdk/emsdk.py
Lines 547 to 553 in 8822664