Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Add an :all target to binary repos #1295

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

attilaolah
Copy link
Contributor

This is the simplest solution to my problem described in #1294.

I'm happy to change this to something more specific, e.g. by exporting only the files I currently need, but it seems like having an :all target is the most future-proof way here.

Closes #1294.

This is the simplest solution to my problem described in #1294. I'm happy to change this to something more specific, e.g. by exporting only the files I currently need, but it seems like having an :all target is the most future-proof way here.
@sbc100 sbc100 changed the title Add an :all target to binary repos [bazel] Add an :all target to binary repos Oct 30, 2023
@walkingeyerobot walkingeyerobot enabled auto-merge (squash) October 30, 2023 17:54
@kripken
Copy link
Member

kripken commented Oct 30, 2023

Test error is not related and should not block this landing.

@tlively the error is in recent Lattice code in Binaryen,

In file included from /root/project/binaryen/main/src/tools/wasm-fuzz-lattices.cpp:21:0:
/usr/include/c++/7/variant: In instantiation of 'constexpr const size_t std::variant_size_v<wasm::RandomFullLattice::L>':
/usr/include/c++/7/variant:702:10:   required from 'struct std::__detail::__variant::__gen_vtable<wasm::RandomFullLattice::ElementImpl, wasm::RandomFullLattice::getBottom() const::<lambda(const auto:5&)>&&, wasm::RandomFullLattice::L&>'
/usr/include/c++/7/variant:1255:23:   required from 'constexpr decltype(auto) std::visit(_Visitor&&, _Variants&& ...) [with _Visitor = wasm::RandomFullLattice::getBottom() const::<lambda(const auto:5&)>; _Variants = {wasm::RandomFullLattice::L&}]'
/root/project/binaryen/main/src/tools/wasm-fuzz-lattices.cpp:666:29:   required from here
/usr/include/c++/7/variant:97:29: error: incomplete type 'std::variant_size<wasm::RandomFullLattice::L>' used in nested name specifier
     inline constexpr size_t variant_size_v = variant_size<_Variant>::value;
                             ^~~~~~~~~~~~~~

@kripken kripken disabled auto-merge October 30, 2023 19:33
@kripken kripken merged commit 34e6772 into emscripten-core:main Oct 30, 2023
9 of 10 checks passed
@attilaolah attilaolah deleted the issue-1294 branch October 31, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export all files as @emscripten_bin_{platform}//:all
3 participants