Fixing issues with pthread implementation #8623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch aims for fixing failures in pthread related POSIX test from clone of http://posixtest.sourceforge.net/ Following problems are addresed: 1. pthread_exit/2-2 test fails sometimes: Exit handlers must execute before setting threadStatus to exited (1). That's because setting threadStatus to 1 means main thread is free to deallocate the thread object. pthread_join is waiting for threadStatus to be set to 1. 2. pthread_cond_wait/2-3 test hang - Disabling recursive thread cancellation. - Allowing __timedwait_cp to be true cancellation point as _cp suffix suggests - Using PTHREAD_CANCEL_MASKED in __timedwait instead of pthread_cond_timedwait as in original musl implementation, because: 1. pthread_cond_timedwait is cancellation point 2. need to mark properly __timedwait as non cancellation point wait. 3. pthread_getschedparam/1-3 test hangs sometimes: In pthread_barrier_wait adding check if lock is held by main thread and waiting on futex in small slices of time there, to check if there is some work to do on behalf of Worker Threads.
Adding [email protected] to AUTHOURS file.
|
Hey just so you know I'm working on a PR that implements/fixes detachable threads (and also fixes the leak in PThread.pthreads): #8286. Our changes look pretty independent, but I just thought you'd like to know. |
|
@VirtualTim thanks for info :) |
|
@juj, can you please take a look at this one, you know this code the best? |
|
I think this was closed by mistake when we deleted the incoming branch (after switching to master), sorry about that. If this PR is still relevant please reopen and retarget to master. |
|
I've checked and this PR is still relevant (tests from POSIX test suite hangs without this PR). However I've created new PR #10524 with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim at fixing some pthread implementation defects (in JavaScript glue layer) discovered when running POSIX tests from http://posixtest.sourceforge.net/ compiled to WebAssembly.