Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_dylink_function_pointer_equality test #8330

Merged
merged 2 commits into from
Mar 25, 2019

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Mar 22, 2019

This test currently is currently expected to fail, until we fix
this issue:

See #8268.

This test currently is currently expected to fail, until we fix
this issue;

See #8268.
@sbc100 sbc100 requested a review from kripken March 25, 2019 20:21
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(is this intended to land disabled? or not land until we fix it?)

@sbc100
Copy link
Collaborator Author

sbc100 commented Mar 25, 2019

It currently checks for failure. Intended to switch to passing when we make this work. Mostly I wanted to prove it was currently broken.

@sbc100 sbc100 merged commit 7341278 into incoming Mar 25, 2019
@sbc100 sbc100 deleted the function_pointer_equality branch March 25, 2019 23:59
VirtualTim pushed a commit to VirtualTim/emscripten that referenced this pull request May 21, 2019
This test currently is currently expected to fail, until we fix
this issue;

See emscripten-core#8268.
VirtualTim added a commit to VirtualTim/emscripten that referenced this pull request May 23, 2019
VirtualTim added a commit to VirtualTim/emscripten that referenced this pull request May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants