Remove -soname from UNSUPPORTED_LLD_FLAGS #23453
Open
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually wasm-ld does now support |
mcbarton
force-pushed
the
main
branch
2 times, most recently
from
64b0bce to
9239fc4
Compare
sbc100
changed the title
mcbarton
changed the title
|
@sbc100 I didn't realise you had already changed the title. Please change it to the one you wanted. I have made the change you requested. |
sbc100
approved these changes
Jan 17, 2025
|
@sbc100 can you rerun the failing circle ci job? Its failing due to an internet connection loss while trying to install ninja-build. |
auto-merge was automatically disabled
January 17, 2025 22:25
Head branch was pushed to by a user without write access
|
@sbc100 You'll need to approve again, as I rebased in order to get the circle ci to run again (to hopefully have ninja-build job work fine now). |
|
@sbc100 can you approve the one workflow to run which requires your approval to run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm-ld supports this flag as of https://reviews.llvm.org/D158001 so there is no need to remove it or warn when it is used.