Fix wasm workers under node #22721
Fix wasm workers under node #22721
Conversation
sbc100
force-pushed
the
wasm_worker_node
branch
4 times, most recently
from
f53fb7a
to
c02abb5
Compare
sbc100
force-pushed
the
wasm_worker_node
branch
2 times, most recently
from
9e79888
to
ac37d0b
Compare
sbc100
force-pushed
the
wasm_worker_node
branch
from
ac37d0b
to
c9b2d8d
Compare
sbc100
force-pushed
the
wasm_worker_node
branch
2 times, most recently
from
1eb97cb
to
d20e9e0
Compare
There was a problem hiding this comment.
LGTM. Though it is not precisely clear to me which part of this PR was the functional fix, and which part of the PR is nonfunctional/cleanup, since there are multiple orthogonal changes layered to this PR. (in particular, was refactoring to use callUserCallback() a needed correctness fix for Node, and was removing use of dynCalls in test_wasm_worker_terminate test necessary for Node?)
I feel a bit that if I proposed this PR, it might get reviewed to need to be split to multiple parts with nonfunctional and functional changes separate 😅 - but since I do argue towards having fast development ergonomy and flow, I think it's fine.
I pretty sure everything here in the PR is essential to get the tests running under node. Sorry I should have documented in the PR description why each change is needed. I will do that now. |
sbc100
force-pushed
the
wasm_worker_node
branch
from
d20e9e0
to
d5ce760
Compare
sbc100
force-pushed
the
wasm_worker_node
branch
from
d5ce760
to
59d5100
Compare
We we not calling `writeStackCookie()` in the right place which means that `checkStackCookie()` would always fail in wasm workers. Required for #22721
sbc100
force-pushed
the
wasm_worker_node
branch
from
59d5100
to
fb229d2
Compare
sbc100
force-pushed
the
wasm_worker_node
branch
2 times, most recently
from
ecec63e
to
f17ce9c
Compare
|
I updated the PR description to detail why these changes are needed and split out some parts into cleanup PRs. |
sbc100
force-pushed
the
wasm_worker_node
branch
from
f17ce9c
to
06855fd
Compare
sbc100
force-pushed
the
wasm_worker_node
branch
from
06855fd
to
386bff2
Compare
- Use callUserCallback to invoke callback in _wasmWorkerRunPostMessage. Without this calls to exit/emscripten_force_exit within the callback don't work as expected (they cause unhandled exception errors). - Fix `onmessage` handling under node so that the message payload always arrives as the `data` member of the message. - Update a few of the wasm workers tests do they actually exit (required for running tests under node).
sbc100
force-pushed
the
wasm_worker_node
branch
from
386bff2
to
172855b
Compare
Without this calls to exit/emscripten_force_exit within the callback
don't work as expected (they cause unhandled exception errors).
onmessagehandling under node so that the message payload alwaysarrives as the
datamember of the message.for running tests under node).