Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SUPPORT_BIG_ENDIAN settings #21752

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix SUPPORT_BIG_ENDIAN settings #21752

merged 1 commit into from
Apr 12, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Apr 12, 2024

Fixes: #21751

@sbc100 sbc100 requested review from dschuff and kripken April 12, 2024 00:41
@dschuff
Copy link
Member

dschuff commented Apr 12, 2024

We have a SUPPORT_BIG_ENDIAN setting⁉️ 🤯

@sbc100 sbc100 merged commit 46bd566 into emscripten-core:main Apr 12, 2024
27 of 29 checks passed
@sbc100 sbc100 deleted the support_big_endian branch April 12, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschuff dschuff dschuff approved these changes

@kripken kripken Awaiting requested review from kripken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SUPPORT_BIG_ENDIAN=1 causes internal compiler error ReferenceError: maybeExport is not defined
2 participants
@sbc100 @dschuff