Rename the exports variable in preamble.js to instExports
#20231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a bug (or limitation) in Google's Closure compiler that does not allow any variable named `exports` to be reassigned. Without this change, some build configurations result in an error message like this:
```
[JSC_EXPORT_NOT_AT_MODULE_SCOPE] Exports must be at the top-level of a module 543|
exports = Asyncify.instrumentWasmExports(exports);
```
The Closure logic lives here, and is intended to block Closure's module exports object from getting reassigned: https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/ClosureCheckModule.java#L436
Since the exports variable used in the preamble is not related to Closure modules, simply renaming the variable does the trick.
|
The name we use elsewhere for this is |
sbc100
reviewed
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a bug (or limitation) in Google's Closure compiler that does not allow any variable named
exportsto be reassigned. Without this change, some build configurations result in an error message like this:The Closure logic lives here, and is intended to block Closure's module exports object from getting reassigned.
Since the exports variable used in the preamble is not related to Closure modules, simply renaming the variable does the trick.
The name
instExportsis already used elsewhere in the preamble to refer to the same thing, so it seems like a good choice here as well.