-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some linux-specific musl headers #17704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the arch file for emscripten sounds good, but the other changes are in generic code, which means they'll show up in diffs to upstream musl and make upgrading less simple, won't they?
All of the other changes to upstream header are simply removing entire files. I decided it was cleaner just to remove them completely. We could create a list of files to exclude in |
The only other change in this PR is a change to test file.. |
Add a ChangeLog entry just in case. |
f4fb5d7
to
84bdabc
Compare
It's easy to avoid re-adding them, but it is another thing to need to remember to do. Musl adding a new file might be confusing here, also - both would look like a file that only exists in upstream. I'm not strongly opposed, but this seems like fairly low benefit, and there is some risk of breakage (like happened in our tests, it seems) so I'm not sure this is worth it? How big do you see the benefit as? |
We don't implement any of the functions declared in these headers, so there is not real use them, and I think it can be misleading to allow them to be included at compile time. See #17638
84bdabc
to
562e853
Compare
I updated the When I run Also, note that we had already pruned at least one file prior to this change "sendfile.h". See #16234 |
And #14248 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fair enough. I don't feel strongly and those are reasonable reasons.
We don't implement any of the functions declared in these headers, so
there is not real use for them, and I think it can be misleading to allow
them to be included at compile time.
See already did this for sendfile.h: #14248
See #17638