-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missed musl sendfile.h #16200
Add missed musl sendfile.h #16200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. A clear compile error sounds good.
Maybe the text could be "sendfile is not supported" instead of "was removed"?
@sbc100 what do you think?
Why not simply not include it? |
I think if a header file is completely unsupported (e.g. windows.h) is seems reasonable to not include it at all. |
We should probably remove a bunch of other linux-specific headers too I guess. |
From my point of view, a project I was compiling with 1.39.6 could no longer compile when upgrading to 3.1.3. As the error was a missing system header I thought something was wrong with my Emscripten setup. I wasted a bunch of time before I released that the file had actually been intentionally removed. I could also see this being useful for people trying to port existing software, as something like this will actually tell them what to do. Maybe instead of this the removal of |
Certainly, adding a changelog entry makes sense to me. |
Closed in favour of just updating the changelog. |
For some reason this file was missing, but is present in the musl repo: https://github.com/emscripten-core/musl/blob/master/include/sys/sendfile.h.
I created a bug on emsdk (emscripten-core/emsdk#983), but it looks like the issue was actually here.
Edit: I realise now that this file was intentionally removed (#14248). I've replaced the contents with a compiler warning linking to the PR that removed.
I don't know if this is a good idea or not, so welcome some input.