-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Debugging docs #14052
Update the Debugging docs #14052
Conversation
@pfaffe Did you see the CI failures on the PR? Some cross-refs look invalid. |
Anything I can help with here? These docs would be useful, as we get questions about this topic, see e.g. #12195 (comment) |
The docs error is that Also merging in latest main will fix the other issues. |
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
Happy I found this PR! Can we land the doc updates please?
I could handle this, assuming the content of this PR is still accurate. relevant: #17814 |
detailed debugging experience and is supported as an experiment in Chrome 88 | ||
with an `extension <https://goo.gle/wasm-debugging-extension>`. See | ||
`here <https://developer.chrome.com/blog/wasm-debugging-2020/>` for a detailed | ||
usage guide. Source maps are more widely supported in Firefox, Chrome, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the content is still accurate. Please feel free to take care of landing the PR if you're interested! |
``llvm-dwp`` tool then, but that could happen in parallel to the linking of | ||
the compiled output! A compatible version should be part of your emscripten | ||
distribution, for example in ``$EMSDK/upstream/bin/llvm-dwp``. When running it | ||
after linking, it's as simple as ``llvm-dwp -e foo.wasm -o foo.wasm.dwp``, or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be emdwp
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, nice catch! emdwp
eliminates having to look up the path in upstream/bin as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping the docs up-to-date!
|
||
``-gsplit-dwarf`` | ||
Enable debug fission, which creates split DWARF object files alongside the | ||
wasm object files. This option must be used together with ``-c``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? -gsplit-dwarf
only makes sense when compiling and not when linking?
Yup this is obsolete now, closing! Thanks for landing, Connor! |
Add some details for -gseparate-dwarf and -gsplit-dwarf.