Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several tests fail on Windows due to a node.js bug. #2582

Closed
juj opened this issue Jul 25, 2014 · 2 comments · Fixed by #2587
Closed

Several tests fail on Windows due to a node.js bug. #2582

juj opened this issue Jul 25, 2014 · 2 comments · Fixed by #2587
Assignees

Comments

@juj
Copy link
Collaborator

juj commented Jul 25, 2014

After the commit 14544cf , several tests began to fail on Windows: http://clb.demon.fi:8112/builders/win-incoming/builds/257/steps/Tests-other/logs/stdio

The affected tests:

other.test_no_exit_runtime
other.test_warn_undefined
other.test_unaligned_memory
other.test_stat_silly
other.test_simd
other.test_prepre
other.test_multidynamic_link
other.test_mdkir_silly
other.test_link_memcpy
other.test_init_file_at_offset
other.test_global_inits
other.test_emversion
other.test_embed_file_dup
other.test_dup_o_in_a
other.test_demangle

The cause of the failure was reduced to a Python bug, which I reported here: http://bugs.python.org/issue22066

As a workaround, reverting the line process.exit(status); back to throw new ExitStatus(status); lets the tests pass. I'm looking for a better workaround now.

@juj
Copy link
Collaborator Author

juj commented Jul 27, 2014

Further testing makes it look like that this is not actually an issue in python, but a node.js issue nodejs/node-v0.x-archive#1669 , which I see @kripken has commented on before as well.

@juj juj changed the title Several tests fail on Windows due to a Python bug. Several tests fail on Windows due to a node.js bug. Jul 27, 2014
@juj juj self-assigned this Jul 28, 2014
juj added a commit that referenced this issue Jul 31, 2014
… fix other.test_warn_undefined on Windows. The end of the output buffer would not get printed during the test, which would cause the test to fail. See also #2582
@juj juj closed this as completed in 90e9dd0 Aug 5, 2014
@juj
Copy link
Collaborator Author

juj commented Sep 7, 2014

The underlying issue is now reported fresh at nodejs/node-v0.x-archive#8329 , since it still occurs and the previous reports of this in node.js repo have either been closed or are a bit different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant