Don't consider library elements marked as __internal during `export…

…Runtime` (#16441) We don't want folks to be able to export internal stuff, and it also helps reduce code size for debug builds.
emscripten-core · Mar 8, 2022 · cdd54fd · cdd54fd
1 parent 9e84db9
commit cdd54fd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/modules.js b/src/modules.js
@@ -441,7 +441,7 @@ function exportRuntime() {
   // Add JS library elements such as FS, GL, ENV, etc. These are prefixed with
   // '$ which indicates they are JS methods.
   for (const ident in LibraryManager.library) {
-    if (ident[0] === '$' && !isJsLibraryConfigIdentifier(ident)) {
+    if (ident[0] === '$' && !isJsLibraryConfigIdentifier(ident) && !LibraryManager.library[ident + '__internal']) {
       runtimeElements.push(ident.substr(1));
     }
   }

diff --git a/tests/other/metadce/hello_world.jssize b/tests/other/metadce/hello_world.jssize
@@ -1 +1 @@
-91448
+91067
diff --git a/tests/other/metadce/minimal.jssize b/tests/other/metadce/minimal.jssize
@@ -1 +1 @@
-88706
+88325