refactor(admin/datatable): use correct translation keys and crud overview #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theus77
reviewed
Jul 23, 2024
| @@ -32,7 +33,9 @@ public function index(Request $request): Response | |||
| { | |||
| $table = $this->dataTableFactory->create(ChannelDataTableType::class); | |||
|
|
|||
| $form = $this->createForm(TableType::class, $table); | |||
| $form = $this->createForm(TableType::class, $table, [ | |||
| 'reorder_label' => t('type.reorder', ['type' => 'channel'],'emsco-core') | |||
There was a problem hiding this comment.
Then the pattern 'channel' is not translatable ?
There was a problem hiding this comment.
channel is just the type for the translation key and is translated
type:
reorder: |-
{type, select,
channel {Reorder channels}
other {Reorder}
}More info about this format https://symfony.com/doc/current/reference/formats/message_format.html#selecting-different-messages-based-on-a-condition
| ); | ||
| $table->addItemPostAction( | ||
| route: 'ems_core_channel_delete', | ||
| labelKey: t('action.delete', [], 'emsco-core'), |
There was a problem hiding this comment.
I think there is a constant for 'emsco-core'
There was a problem hiding this comment.
Using the t() function with a constant makes that the crawler will not detect the key. To make our translations automatically build with php build/translations en EMSCoreBundle --write --format=yml -d emsco-core we can not use constants as translation domain.
Toolbar can now be defined in the dataTableType
Davidmattei
force-pushed
the
refactor/datatables-part2
branch
from
8b57c32 to
ae853cf
Compare
Davidmattei
force-pushed
the
refactor/datatables-part2
branch
from
cdc1a45 to
aed4e07
Compare
Davidmattei
force-pushed
the
refactor/datatables-part2
branch
from
2d068c4 to
903246e
Compare
Davidmattei
force-pushed
the
refactor/datatables-part2
branch
from
b2fa6ff to
9ab745f
Compare
It is the overview of the uploaded asset for publishers
Use UploadedAssetDataTableType for: - pick file from server (file field) - browser file (from wysiwyg ckeditor modal) - publisher overview. Because the uploadedAsset query should be same, grouped by hash.
- Improved routing actions and using constants. - /publisher checked by security.yaml - Renamed UploadedAssetLogDatatable to UploadedAssetAdminDataTableType.php
Remove unneeded nesting
level_name should be entity property levelName
and remove index.html.twig for crud/index.html.twig
theus77
approved these changes
Jul 25, 2024
Davidmattei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the index templates for the following:
Extra:
Toolbar actions can now be defined in the dataTableType.
For the uploaded asset/file controller, I refactored the route naming using constants. The publisher and admin route actions are in the same controller, but now the action name is prefix (publisherOverview, adminOverview)
Reused the uploadedFileDataTable for wysiwyg modals, file pick modal and publisher overview. On all 3 places we a group by sha1. Only on the admin datatable (Uploaded file logs) we do not group by sha1.
Added a new DashboardDefinition enum