Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin/revision): collection enter key triggers delete first item #954

Merged

Conversation

Davidmattei
Copy link
Member

Q A
Bug fix? y
New feature? n
BC breaks? n
Deprecations? n
Fixed tickets? #936
Documentation? n

Because the remove collection item button is a submit button. It's better to just define in the button in twig.
Javascript is listining for a button with the class 'remove-content-button'

@Davidmattei Davidmattei requested a review from a team as a code owner July 12, 2024 06:53
@Davidmattei Davidmattei added this to the 5.19.0 milestone Jul 12, 2024
@Davidmattei Davidmattei self-assigned this Jul 12, 2024
@Davidmattei Davidmattei merged commit abe4ca6 into ems-project:5.x Jul 12, 2024
2 checks passed
@Davidmattei Davidmattei changed the title fix(core/revision): collection enter key triggers delete first item fix(admin/revision): collection enter key triggers delete first item Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

"Enter" key in collection provokes the "remove" action of the first entry in the collection
2 participants