feat(admin/revision): improve datatable drafts and trash #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to define the queryService directly in the dataTable type.
If we define an ORM query we should just return entities
We can remove the overkill service DraftInProgress.php
Only used inside RevisionDraftsDataTableType.php and overkill
Davidmattei
changed the title
Because it is used for bulk button (deleting selection)
Improved the emsco_display, if the revision is not in any environment, we know it is a new revision. If EMSCO_PRE_GENERATE_OUUIDS is not enabled we do not have anything to print. It is cleaner to just print 'New %contentType singular name%'
Like in others tables, first column (after checkbox) should be the label of the revision.
The revision trash datatable can now also use an orm queryBuilder just like the drafts table. Added a new makeQueryBuilder method in the revisionRepository. By default it returns active, not deleted, not drafts revisions.
Also align form/fields.twig with adminUI bundle
Davidmattei
changed the title
theus77
approved these changes
Jul 17, 2024
Davidmattei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR refactored the trash & drafts datatables.
Removed the need of separate services for building a table. The query is now build inside the type and ask the queryBuilder from the RevisionRepository. The dataTableType just needs to implement QueryServiceTypeInterface
Replaced index view by new generic crud/overview.html.twig
Other fixes: