feat(admin/wysiwyg): add data attributes in iframe preview #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Davidmattei
commented
Oct 3, 2024
•
Davidmattei
commented
| Q | A |
|---|---|
| Bug fix? | y |
| New feature? | y |
| BC breaks? | n |
| Deprecations? | n |
| Fixed tickets? | n |
| Documentation? | y |
- Add a new Locale standard for calculating the short (2 digits) version of a locale
- Container field add display option 'language' (passed to all children like multiplex)
- Form option locale use language option if defined (language option can be passed by parent (container or multiplex)
- Add data-field and data-document-url on body tag inside iframe preview
- Add example of javascript in documentation
- Update the admin UI template
theus77
reviewed
Oct 3, 2024
EMS/core-bundle/src/Resources/views/macros/data-field-type.html.twig
Outdated
Show resolved
Hide resolved
theus77
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.