Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable/disable verification email #119

Closed
wants to merge 2 commits into from
Closed

Conversation

vipinks
Copy link
Contributor

@vipinks vipinks commented Apr 29, 2016

verification email sending can be disabled while creating user manually from site's admin area, as of now it only checks verification from config file. It is ok for website's frontend user registration, but what if an admin wants to stop verification email while creating users manually? Developers don't have choice to give a functionality to non programmer admins or admins who don't have access to aauth.php config file.

flexibility to disable verification email while calling create_user function form or inside admin area of the site. As the current version always looks this in config file. that is ok for site's frontend registration but what if an admin creates user from admin area, the library will send verification every time.
@REJack
Copy link
Collaborator

REJack commented Apr 29, 2016

we could also change only
if($this->config_vars['verification']){ in line 747 to
if($this->config_vars['verification'] && !$this->is_admin()){

@vipinks
Copy link
Contributor Author

vipinks commented Apr 29, 2016

@REJack Yes that's a good one.

@REJack
Copy link
Collaborator

REJack commented May 1, 2016

@vipinks i can add this in my PR, if you close your PR 😃

@vipinks
Copy link
Contributor Author

vipinks commented May 1, 2016

Sure buddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants