Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emqtt): should retry after reconnect #166

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Aug 24, 2022

Prior to this fix, the expired retry timer may not get the chance
to refresh if it's not at the 'connected' state.

A ensure_retry_timer call is added to the state transition
from waiting_for_connack to connected

@zmstone zmstone requested a review from a team August 24, 2022 18:27
@zmstone zmstone force-pushed the fix-retry-when-reconnect-is-allowed branch from cb65ea0 to 9cb1a79 Compare August 25, 2022 08:59
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
Prior to this fix, the expired retry timer may not get the chance
to refresh if it's not at the 'connected' state.

A ensure_retry_timer call is added to the state transition
from waiting_for_connack to connected
@zmstone zmstone force-pushed the fix-retry-when-reconnect-is-allowed branch from 24904f7 to 546dcd7 Compare August 25, 2022 14:19
@zmstone
Copy link
Member Author

zmstone commented Aug 25, 2022

squashed commits.

@zmstone zmstone merged commit 9978799 into master Aug 26, 2022
@zmstone zmstone deleted the fix-retry-when-reconnect-is-allowed branch August 26, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants