Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.7.0: Impl sync/async publish API #165

Merged
merged 22 commits into from
Aug 24, 2022
Merged

1.7.0: Impl sync/async publish API #165

merged 22 commits into from
Aug 24, 2022

Conversation

HJianBo
Copy link
Member

@HJianBo HJianBo commented Aug 18, 2022

No description provided.

@HJianBo HJianBo marked this pull request as draft August 18, 2022 09:11
@HJianBo HJianBo marked this pull request as ready for review August 18, 2022 10:40
@HJianBo HJianBo requested review from terry-xiaoyu, zmstone and a team August 18, 2022 10:41
@zmstone
Copy link
Member

zmstone commented Aug 18, 2022

no appup ?

zmstone
zmstone reviewed Aug 18, 2022
View reviewed changes
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Aug 18, 2022
View reviewed changes
src/emqtt.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Aug 18, 2022
View reviewed changes
src/emqtt.erl Show resolved Hide resolved
zmstone
zmstone reviewed Aug 18, 2022
View reviewed changes
src/emqtt.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Aug 18, 2022
View reviewed changes
src/emqtt.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Aug 18, 2022
View reviewed changes
src/emqtt.erl Outdated Show resolved Hide resolved
@HJianBo HJianBo requested a review from zmstone August 22, 2022 06:07
@HJianBo HJianBo changed the title feat: support async publish 1.7.0: Impl sync/async publish API Aug 22, 2022
@HJianBo HJianBo requested a review from a team August 22, 2022 09:53
zmstone
zmstone reviewed Aug 22, 2022
View reviewed changes
src/emqtt.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Aug 22, 2022
View reviewed changes
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
@zmstone
Copy link
Member

zmstone commented Aug 22, 2022

the Inflight should be treated as an opaque data structure.
maybe put it to a separate module and expose APIs:

  • count
  • add
  • update
  • delete
  • to_sorted_list % sort sent message in the original send order, so retries and batched-replies can be applied in determined order

thalesmg
thalesmg reviewed Aug 22, 2022
View reviewed changes
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
test/emqtt_SUITE.erl Outdated Show resolved Hide resolved
src/emqtt.erl Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
@HJianBo HJianBo requested review from zmstone and a team August 23, 2022 06:40
zmstone
zmstone reviewed Aug 23, 2022
View reviewed changes
src/emqtt.erl Show resolved Hide resolved
ieQu1
ieQu1 reviewed Aug 23, 2022
View reviewed changes
test/emqtt_SUITE.erl Outdated Show resolved Hide resolved
ieQu1
ieQu1 reviewed Aug 23, 2022
View reviewed changes
src/emqtt_inflight.erl Outdated Show resolved Hide resolved
thalesmg
thalesmg reviewed Aug 23, 2022
View reviewed changes
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt_inflight.erl Outdated Show resolved Hide resolved
src/emqtt_inflight.erl Outdated Show resolved Hide resolved
src/emqtt.erl Outdated Show resolved Hide resolved
src/emqtt_inflight.erl Outdated Show resolved Hide resolved
src/emqtt_inflight.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Aug 23, 2022
View reviewed changes
src/emqtt_inflight.erl Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Aug 23, 2022
View reviewed changes
src/emqtt.erl Outdated Show resolved Hide resolved
@HJianBo HJianBo mentioned this pull request Aug 24, 2022
Merged
zmstone
zmstone reviewed Aug 24, 2022
View reviewed changes
src/emqtt.erl Outdated Show resolved Hide resolved
thalesmg
thalesmg approved these changes Aug 24, 2022
View reviewed changes
Makefile Show resolved Hide resolved
@zmstone zmstone merged commit 53369dc into master Aug 24, 2022
@zmstone zmstone deleted the add_async_publish branch August 24, 2022 18:23
@HJianBo HJianBo mentioned this pull request Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone zmstone left review comments

@ieQu1 ieQu1 ieQu1 approved these changes

@thalesmg thalesmg thalesmg approved these changes

@qzhuyan qzhuyan qzhuyan approved these changes

@terry-xiaoyu terry-xiaoyu Awaiting requested review from terry-xiaoyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HJianBo @zmstone @qzhuyan @terry-xiaoyu @thalesmg @ieQu1