Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(desktop): support rebuild database when load connection error #1711

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Jul 4, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

The user database encountered an issue with missing fields under uncertain circumstances, and the migration script couldn't resolve it.

image

image

Issue Number

Example: https://askemq.com/t/topic/8672/2

What is the new behavior?

This is a temporary solution: we will reuse the previous database error component to rebuild the database file. The downside is that it will cause the loss of database content. We will continue to optimize and improve the data migration method in the future.

image

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added fix Fix bug or issues migration database migration desktop MQTTX Desktop labels Jul 4, 2024
@ysfscream ysfscream added this to the v1.10.1 milestone Jul 4, 2024
@ysfscream ysfscream requested a review from Red-Asuka July 4, 2024 09:48
@ysfscream ysfscream self-assigned this Jul 4, 2024
@ysfscream ysfscream requested a review from XL-YiBai July 4, 2024 09:49
@Red-Asuka Red-Asuka merged commit 192e541 into main Jul 5, 2024
2 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch July 5, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop fix Fix bug or issues migration database migration
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants