Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Desktop Backup Import #1701

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Improve the Desktop Backup Import #1701

merged 4 commits into from
Jun 25, 2024

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Jun 21, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Data import does not allow file path updates. You can only select files via Dialog.

Can not import extensive data included on backup file.

Issue Number

Example: #1696

What is the new behavior?

You can now update the file content by manually inputting a new path, not just by selecting the file via Dialog.

Support showing importing progress, allowing users to monitor the current status.

image image

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known before review?

Other information

@ysfscream ysfscream added enhancement New feature or request fix Fix bug or issues desktop MQTTX Desktop labels Jun 21, 2024
@ysfscream ysfscream added this to the v1.10.1 milestone Jun 21, 2024
@ysfscream ysfscream requested a review from Red-Asuka June 21, 2024 07:41
@ysfscream ysfscream self-assigned this Jun 21, 2024
@ysfscream ysfscream marked this pull request as draft June 21, 2024 15:00
@ysfscream ysfscream changed the title fix(desktop): fix can not update file path on data import fix(desktop): fix can not import large data on backup file Jun 21, 2024
@ysfscream ysfscream added the feature This pr is a feature label Jun 21, 2024
@ysfscream ysfscream changed the title fix(desktop): fix can not import large data on backup file Improve the Desktop Backup Import Jun 21, 2024
@ysfscream ysfscream marked this pull request as ready for review June 24, 2024 17:29
@Red-Asuka Red-Asuka merged commit b0a7f7c into main Jun 25, 2024
1 check passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch June 25, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request feature This pr is a feature fix Fix bug or issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants