Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR used for webhooks test #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PR used for webhooks test #52

wants to merge 1 commit into from

Conversation

knorrest
Copy link
Contributor

@knorrest knorrest commented May 6, 2021

Change-Id: I5c99a79845b9cc165bd11d8d721ad5c569497141

@knorrest knorrest changed the title add crap PR used for webhooks test May 6, 2021
add crap
9c163ca 
Change-Id: I5c99a79845b9cc165bd11d8d721ad5c569497141
@empear-analytics empear-analytics deleted a comment from emilaasa Jan 6, 2022
@RokLenarcic
Copy link

CodeScene PR Check
Quality Gates FAILED
Recommended Review Level Some type of review...

Warnings

Modifies Hotspot

  • test-aspnet-mvc-repo/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/ViewComponentResultTest.cs

Complexity Trend Warning

  • test-aspnet-mvc-repo/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/ControllerActionInvokerTest.cs

Degrades in Code Health

  • DefaultViewComponentHelperTest.cs degrades from a Code Health of 10.0 -> 9.0
  • ViewComponentResultTest.cs degrades from a Code Health of 9.3 -> 9.0
  • ControllerActionInvokerTest.cs degrades from a Code Health of 5.0 -> 4.7

Improvements

  • ViewComponentDescriptor.cs improves its Code Health from 8.3 -> 10.0

Code Health Delta Descriptions

test-aspnet-mvc-repo/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/DefaultViewComponentHelperTest.cs

Degradations

  • Duplicated Assertion Blocks - new issue
  • High Degree of Code Duplication - new issue

test-aspnet-mvc-repo/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/ViewComponentResultTest.cs

Improvements

  • String Heavy Function Arguments - no longer an issue
  • Constructor Over-Injection - no longer an issue

Degradations

  • Similar Code in Multiple Functions - new issue

test-aspnet-mvc-repo/test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/ControllerActionInvokerTest.cs

Degradations

  • Constructor Over-Injection - new issue
  • Primitive Obsession - new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knorrest @RokLenarcic