Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primitive components with the CSS Prop doc #992

Closed
wants to merge 3 commits into from
Closed

Primitive components with the CSS Prop doc #992

wants to merge 3 commits into from

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Nov 4, 2018

What:

Why:
#973 (comment)

How:

Checklist:

  • Documentation
  • Tests
  • Code complete

I'm not totally sure about the name "primitive components" because people could think it's related to react-primitives.

@codecov
Copy link

codecov bot commented Nov 4, 2018 •
edited
Loading

Codecov Report

Merging #992 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...ages/eslint-plugin-emotion/src/rules/jsx-import.js 96.77% <0%> (-0.85%) ⬇️
packages/core/src/jsx.js 98% <0%> (-0.42%) ⬇️
packages/core/src/global.js 97.5% <0%> (-0.07%) ⬇️
packages/sheet/src/index.js 100% <0%> (ø) ⬆️
packages/cache/src/index.js 100% <0%> (ø) ⬆️
test/testSetup.js 100% <0%> (+14.28%) ⬆️

@zmitry
Copy link
Contributor

zmitry commented Feb 27, 2019 •
edited
Loading

But how to use component as selectors then ?

@emmatown emmatown closed this Apr 11, 2019
@Andarist Andarist deleted the primitive-components-doc branch November 10, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmatown @zmitry