Add toHaveStyleRule to jest-emotion #662
Conversation
| // This could be done in a more efficient way | ||
| // but it would be a breaking change to do so | ||
| // because it would change the ordering of styles | ||
| Object.keys(emotion.caches.registered).forEach(className => { |
There was a problem hiding this comment.
personally I would replace forEach with reduce here
There was a problem hiding this comment.
I actually copied that block of code from index.js because it did what I needed. Agree it should be refactored 👍
packages/jest-emotion/src/index.js
Outdated
| @@ -37,12 +39,14 @@ function getClassNamesFromDOMElement(selectors, node) { | |||
| return getClassNames(selectors, node.getAttribute('class')) | |||
| } | |||
|
|
|||
| function getClassNamesFromNodes(nodes) { | |||
| export function getClassNamesFromNodes(nodes) { | |||
There was a problem hiding this comment.
Could you move this into a utils file and import it from that file because exporting from here means it’s exported from the main package so people could start using it and if we wanted to change it we would have to do a major version
Codecov Report
|
|
It should be code complete now, I'll see what I can do about increasing the code coverage though. I'm not sure how to add a new dependency to a package. I tried |
|
Thanks! |
|
Hey guys! Great that this feature is finally merged to master, really looking forward to using it! |
|
We hope to make a new release this week, can't promise anything though. |
What:
Feature: adding
toHaveStyleRuletojest-emotion.Why:
This utility is provided by
jest-styled-componentsandjest-glamor-react, so is a blocker for people wanting to port toemotion. Already tracked here: #645How:
I originally wrote the utility for
jest-glamor-reactand that was in turn based on the same utility injest-styled-components.Checklist: