Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Babel plugin usage in install docs #407

Merged
merged 1 commit into from
Oct 14, 2017
Merged

Clarify Babel plugin usage in install docs #407

merged 1 commit into from
Oct 14, 2017

Conversation

wKovacs64
Copy link
Contributor

What:

Update install docs with regards to the Babel plugin to remove any confusion surrounding transform-react-constant-elements being related to emotion.

Why:

People new to emotion and CSS-in-JS in general may not know if transform-react-constant-elements is related to emotion and whether or not it's required to use emotion's Babel plugin.

How:

Remove reference to transform-react-constant-elements by substituting a fictitious plugin to show it is only there to illustrate order.

Checklist:

  • Documentation
  • Tests N/A
  • Code complete N/A

@tkh44
Copy link
Member

tkh44 commented Oct 14, 2017

Thank you!

@tkh44 tkh44 merged commit 9777fb3 into emotion-js:master Oct 14, 2017
@wKovacs64 wKovacs64 deleted the docs-install branch October 14, 2017 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants