Fixed an issue with the lack of /*#__PURE__*/ annotations before styled calls transformed from tagged template expressions
#2799
Conversation
🦋 Changeset detectedLatest commit: 87a7a22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 87a7a22:
|
Codecov Report
|
|
@mitchellhamilton would love a second pair of eyes on this one. The build of the site has failed here but it's rather for an unrelated reason. There is a PR that rewrites the site from Gatsby to Next.js - I hope it will resolve such issues (and it will be easier to maintain for us). |
| : reference.parentPath.parentPath.isTaggedTemplateExpression() | ||
| ? reference.parentPath.parentPath |
There was a problem hiding this comment.
When will this case happen? If it's a valid styled call, won't createStyledComponentPath always be set?
There was a problem hiding this comment.
It was indeed redundant, some leftover from a WIP - I had to add this to workaround a bug in the code leading to this but it seems that I later fixed the underlying issue. I've cleaned up this redundant code and everything looks OK, thanks for noticing!
# Conflicts: # site/package.json # yarn.lock
fixes #2619