Use ESLint directly #231
Merged
Use ESLint directly #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=======================================
Coverage 90.31% 90.31%
=======================================
Files 20 20
Lines 971 971
Branches 263 263
=======================================
Hits 877 877
Misses 76 76
Partials 18 18
Continue to review full report at Codecov.
|
This was referenced Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Use ESLint directly with
eslint-config-standard,eslint-config-standard-react,eslint-config-prettierandeslint-plugin-prettier.Why:
So that if code isn't in Prettier's style Travis fails. This also only requires people to have a single editor plugin.
How:
Checklist: