Prop filtering #227
Merged
Prop filtering #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmatown
commented
Aug 4, 2017
|  | ||
|  | ||
|  | ||
|  |
There was a problem hiding this comment.
I'm not sure if it's clear enough that the react size includes the core size.
There was a problem hiding this comment.
Don't worry about it for the pr. If it looks confusing we can edit the readme later.
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 90.27% 90.31% +0.04%
==========================================
Files 20 20
Lines 967 971 +4
Branches 261 263 +2
==========================================
+ Hits 873 877 +4
Misses 76 76
Partials 18 18
Continue to review full report at Codecov.
|
This was referenced Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Filter props on string tags.
Why:
#183
How:
Regex generated at build time with
babel-plugin-preval.Checklist:
This adds about 700b to the react version.