Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with dev-only labels not being added when source maps were disabled #2081

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Nov 9, 2020

No description provided.

@Andarist Andarist requested a review from emmatown November 9, 2020 22:54
@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2020

⚠️ No Changeset found

Latest commit: 7a16362

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a16362:

Sandbox Source
Emotion Configuration

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the end of the title is "when source maps are disabled"?

Assuming that, sgtm (besides needing a changeset)

@Andarist Andarist changed the title Fixed an issue with dev-only labels not being added when source maps … Fixed an issue with dev-only labels not being added when source maps were disabled Nov 9, 2020
@Andarist Andarist force-pushed the always-provide-dev-node branch from 03cbfe1 to 7a16362 Compare November 9, 2020 23:05
@Andarist Andarist merged commit 688586d into next Nov 9, 2020
@Andarist Andarist deleted the always-provide-dev-node branch November 9, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants