Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test_unit_dimension_rc1() #798

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Conversation

jesper-friis
Copy link
Collaborator

Description

Allow to select different tests on units depending on the version of EMMO.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (6c1f3d8) to head (9d6d65d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
emmopy/emmocheck.py 30.76% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
- Coverage   72.89%   72.75%   -0.15%     
==========================================
  Files          18       18              
  Lines        3745     3758      +13     
==========================================
+ Hits         2730     2734       +4     
- Misses       1015     1024       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesper-friis jesper-friis changed the title WIP: Added test_unit_dimension_rc1() Added test_unit_dimension_rc1() Dec 4, 2024
@jesper-friis jesper-friis merged commit 45c67ca into master Dec 10, 2024
10 of 12 checks passed
@jesper-friis jesper-friis deleted the test-unit-dimension-rc1 branch December 10, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants