Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HermiT is default reasoner. #671

Merged
merged 7 commits into from
Nov 4, 2023
Merged

HermiT is default reasoner. #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
83a1f23
HermiT is deafault reasoner.
francescalb Nov 3, 2023
9d59faf
Merge branch 'master' into allow_hermit_ontoconvert
francescalb Nov 3, 2023
461e5d7
Moved tests for reasoner into separate file.
francescalb Nov 3, 2023
34a245a
Merge branch 'allow_hermit_ontoconvert' of github.com:emmo-repo/EMMOn…
francescalb Nov 3, 2023
51a1d83
Added new ontology to test reasoning
francescalb Nov 3, 2023
6c60eba
typo
francescalb Nov 3, 2023
bb6900a
Updated sync_reasoner to check for no relation after reasoning
francescalb Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ontopy/ontology.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1230,15 +1230,15 @@ def rename_entities(
break

def sync_reasoner(
self, reasoner="FaCT++", include_imported=False, **kwargs
self, reasoner="HermiT", include_imported=False, **kwargs
):
"""Update current ontology by running the given reasoner.

Supported values for `reasoner` are 'Pellet', 'HermiT' and 'FaCT++'.
Supported values for `reasoner` are 'HermiT' (default), Pellet
and 'FaCT++'.

If `include_imported` is true, the reasoner will also reason
over imported ontologies. Note that this may be **very** slow
with Pellet and HermiT.
over imported ontologies. Note that this may be **very** slow.

Keyword arguments are passed to the underlying owlready2 function.
"""
Expand All @@ -1250,7 +1250,7 @@ def sync_reasoner(
sync = owlready2.sync_reasoner_hermit
else:
raise ValueError(
f"unknown reasoner '{reasoner}'. Supported reasoners "
f"Unknown reasoner '{reasoner}'. Supported reasoners "
"are 'Pellet', 'HermiT' and 'FaCT++'."
)

Expand Down
57 changes: 57 additions & 0 deletions tests/ontopy_tests/test_reasoner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
from typing import TYPE_CHECKING
import pytest

if TYPE_CHECKING:
from pathlib import Path

from ontopy.ontology import Ontology


def test_sync_reasoner_hermit(repo_dir: "Path") -> None:
"""Test `ontopy:Ontology.sync_reasoner()` with HermiT."""
from ontopy import get_ontology

testonto = get_ontology(
repo_dir / "tests" / "testonto" / "testonto_for_reasoner.ttl"
).load()
assert testonto.Avocado
assert not isinstance(testonto.Avocado, testonto.NaturalDye)
testonto.sync_reasoner(reasoner="HermiT")
assert isinstance(testonto.Avocado, testonto.NaturalDye)


def test_sync_reasoner_pellet(repo_dir: "Path") -> None:
"""Test `ontopy:Ontology.sync_reasoner()` with Pellet"""
from ontopy import get_ontology

testonto = get_ontology(
repo_dir / "tests" / "testonto" / "testonto_for_reasoner.ttl"
).load()

assert testonto.Avocado
assert not isinstance(testonto.Avocado, testonto.NaturalDye)
testonto.sync_reasoner(reasoner="Pellet")
assert isinstance(testonto.Avocado, testonto.NaturalDye)


def test_sync_reasoner_fact(repo_dir: "Path") -> None:
"""Test `ontopy:Ontology.sync_reasoner()` with FaCT++"""
from ontopy import get_ontology

testonto = get_ontology(
repo_dir / "tests" / "testonto" / "testonto_for_reasoner.ttl"
).load()
assert testonto.Avocado
assert not isinstance(testonto.Avocado, testonto.NaturalDye)
testonto.sync_reasoner(reasoner="FaCT++")
assert isinstance(testonto.Avocado, testonto.NaturalDye)


def test_sync_reasoner_wrong(testonto: "Ontology") -> None:
"""Test `ontopy:Ontology.sync_reasoner()` with wrong reasoner."""
with pytest.raises(ValueError) as excinfo:
testonto.sync_reasoner(reasoner="NonExistingReasoner")
assert str(excinfo.value) == (
"Unknown reasoner 'NonExistingReasoner'. "
"Supported reasoners are 'Pellet', 'HermiT' and 'FaCT++'."
)
6 changes: 0 additions & 6 deletions tests/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,3 @@ class H2O(emmo.Molecule):
onto.sync_attributes(name_policy="uuid", name_prefix=name_prefix)
assert synced_uuid != water.name
assert water.name.startswith("onto_")


def test_sync_reasoner(testonto: "Ontology") -> None:
"""Test `ontopy:Ontology.sync_reasoner()`."""

testonto.sync_reasoner()
125 changes: 125 additions & 0 deletions tests/testonto/testonto_for_reasoner.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
@prefix : <http://emmo.info/testontology#> .
@prefix owl: <http://www.w3.org/2002/07/owl#> .
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
@prefix xml: <http://www.w3.org/XML/1998/namespace> .
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
@prefix skos: <http://www.w3.org/2004/02/skos/core#> .
@base <http://emmo.info/testontology> .

<http://emmo.info/testontology> rdf:type owl:Ontology ;
owl:versionIRI <http://emmo.info/testonto/0.1.0/testontology> .

#################################################################
# Annotation properties
#################################################################

### http://www.w3.org/2004/02/skos/core#altLabel
skos:altLabel rdf:type owl:AnnotationProperty .


### http://www.w3.org/2004/02/skos/core#prefLabel
skos:prefLabel rdf:type owl:AnnotationProperty .


#################################################################
# Object Properties
#################################################################

### http://emmo.info/testontology#hasColour
:hasColour rdf:type owl:ObjectProperty ;
rdfs:domain :Dye ;
rdfs:range :Colour .


### http://emmo.info/testontology#hasNaturePart
:hasNaturePart rdf:type owl:ObjectProperty ;
rdfs:subPropertyOf :hasPart ;
rdfs:domain :Nature ;
rdfs:range :Nature .


### http://emmo.info/testontology#hasPart
:hasPart rdf:type owl:ObjectProperty .


#################################################################
# Classes
#################################################################

### http://emmo.info/testontology#Avocado
:Avocado rdf:type owl:Class ;
rdfs:subClassOf :EvergreenTree ,
[ rdf:type owl:Restriction ;
owl:onProperty :hasColour ;
owl:qualifiedCardinality "1"^^xsd:nonNegativeInteger ;
owl:onClass :Colour
] ;
skos:prefLabel "Avocado"@en .


### http://emmo.info/testontology#Colour
:Colour rdf:type owl:Class .


### http://emmo.info/testontology#DesiduousTree
:DesiduousTree rdf:type owl:Class ;
rdfs:subClassOf :Tree ;
skos:prefLabel "DesiduousTree"@en .


### http://emmo.info/testontology#Dye
:Dye rdf:type owl:Class .


### http://emmo.info/testontology#EngelmannSpruce
:EngelmannSpruce rdf:type owl:Class ;
rdfs:subClassOf :Spruce ;
skos:prefLabel "EngelmannSpruce"@en .


### http://emmo.info/testontology#EvergreenTree
:EvergreenTree rdf:type owl:Class ;
rdfs:subClassOf :Tree ;
skos:prefLabel "EvergreenTree"@en .


### http://emmo.info/testontology#NaturalDye
:NaturalDye rdf:type owl:Class ;
owl:equivalentClass [ owl:intersectionOf ( :Dye
:Nature
) ;
rdf:type owl:Class
] ;
skos:prefLabel "NaturalDye"@en .


### http://emmo.info/testontology#Nature
:Nature rdf:type owl:Class .


### http://emmo.info/testontology#NorwaySpruce
:NorwaySpruce rdf:type owl:Class ;
rdfs:subClassOf :Spruce ;
skos:prefLabel "NorwaySpruce"@en .


### http://emmo.info/testontology#ShingledHedgehogMushroom
:ShingledHedgehogMushroom rdf:type owl:Class ;
rdfs:subClassOf :NaturalDye ;
skos:prefLabel "ShingledHedgehogMushroom"@en .


### http://emmo.info/testontology#Spruce
:Spruce rdf:type owl:Class ;
rdfs:subClassOf :EvergreenTree ;
skos:prefLabel "Spruce"@en .


### http://emmo.info/testontology#Tree
:Tree rdf:type owl:Class ;
rdfs:subClassOf :Nature ;
skos:prefLabel "Tree"@en .


### Generated by the OWL API (version 4.5.9.2019-02-01T07:24:44Z) https://github.com/owlcs/owlapi
105 changes: 105 additions & 0 deletions tests/testonto/testonto_for_reasoner_inferred.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
@prefix : <http://emmo.info/testonto/0.1.0/testontology#> .
@prefix owl: <http://www.w3.org/2002/07/owl#> .
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
@prefix xml: <http://www.w3.org/XML/1998/namespace> .
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
@base <http://emmo.info/testonto/0.1.0/testontology> .

<http://emmo.info/testonto/0.1.0/testontology> rdf:type owl:Ontology .

#################################################################
# Object Properties
#################################################################

### http://emmo.info/testontology#hasColour
<http://emmo.info/testontology#hasColour> rdf:type owl:ObjectProperty ;
rdfs:domain <http://emmo.info/testontology#Dye> ;
rdfs:range <http://emmo.info/testontology#Colour> .


### http://emmo.info/testontology#hasNaturePart
<http://emmo.info/testontology#hasNaturePart> rdf:type owl:ObjectProperty ;
rdfs:subPropertyOf <http://emmo.info/testontology#hasPart> ;
rdfs:domain <http://emmo.info/testontology#Nature> ;
rdfs:range <http://emmo.info/testontology#Nature> .


### http://emmo.info/testontology#hasPart
<http://emmo.info/testontology#hasPart> rdf:type owl:ObjectProperty .


#################################################################
# Classes
#################################################################

### http://emmo.info/testontology#Avocado
<http://emmo.info/testontology#Avocado> rdf:type owl:Class ;
rdfs:subClassOf <http://emmo.info/testontology#EvergreenTree> ,
<http://emmo.info/testontology#NaturalDye> ,
[ rdf:type owl:Restriction ;
owl:onProperty <http://emmo.info/testontology#hasColour> ;
owl:qualifiedCardinality "1"^^xsd:nonNegativeInteger ;
owl:onClass <http://emmo.info/testontology#Colour>
] .


### http://emmo.info/testontology#Colour
<http://emmo.info/testontology#Colour> rdf:type owl:Class .


### http://emmo.info/testontology#DesiduousTree
<http://emmo.info/testontology#DesiduousTree> rdf:type owl:Class ;
rdfs:subClassOf <http://emmo.info/testontology#Tree> .


### http://emmo.info/testontology#Dye
<http://emmo.info/testontology#Dye> rdf:type owl:Class .


### http://emmo.info/testontology#EngelmannSpruce
<http://emmo.info/testontology#EngelmannSpruce> rdf:type owl:Class ;
rdfs:subClassOf <http://emmo.info/testontology#Spruce> .


### http://emmo.info/testontology#EvergreenTree
<http://emmo.info/testontology#EvergreenTree> rdf:type owl:Class ;
rdfs:subClassOf <http://emmo.info/testontology#Tree> .


### http://emmo.info/testontology#NaturalDye
<http://emmo.info/testontology#NaturalDye> rdf:type owl:Class ;
owl:equivalentClass [ owl:intersectionOf ( <http://emmo.info/testontology#Dye>
<http://emmo.info/testontology#Nature>
) ;
rdf:type owl:Class
] ;
rdfs:subClassOf <http://emmo.info/testontology#Dye> ,
<http://emmo.info/testontology#Nature> .


### http://emmo.info/testontology#Nature
<http://emmo.info/testontology#Nature> rdf:type owl:Class .


### http://emmo.info/testontology#NorwaySpruce
<http://emmo.info/testontology#NorwaySpruce> rdf:type owl:Class ;
rdfs:subClassOf <http://emmo.info/testontology#Spruce> .


### http://emmo.info/testontology#ShingledHedgehogMushroom
<http://emmo.info/testontology#ShingledHedgehogMushroom> rdf:type owl:Class ;
rdfs:subClassOf <http://emmo.info/testontology#NaturalDye> .


### http://emmo.info/testontology#Spruce
<http://emmo.info/testontology#Spruce> rdf:type owl:Class ;
rdfs:subClassOf <http://emmo.info/testontology#EvergreenTree> .


### http://emmo.info/testontology#Tree
<http://emmo.info/testontology#Tree> rdf:type owl:Class ;
rdfs:subClassOf <http://emmo.info/testontology#Nature> .


### Generated by the OWL API (version 4.5.9.2019-02-01T07:24:44Z) https://github.com/owlcs/owlapi
Loading