Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: written ROMs can't be considered "moved" #984

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 3, 2024

No description provided.

@emmercm emmercm self-assigned this Mar 3, 2024
@emmercm emmercm enabled auto-merge (squash) March 3, 2024 04:37
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.36%. Comparing base (2a64c62) to head (73f32ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #984   +/-   ##
=======================================
  Coverage   93.36%   93.36%           
=======================================
  Files          89       89           
  Lines        5577     5580    +3     
  Branches     1299     1299           
=======================================
+ Hits         5207     5210    +3     
  Misses        352      352           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 3, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/written-moved-deconflict" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit d8af7ea into main Mar 3, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/written-moved-deconflict branch March 3, 2024 04:42
Copy link

github-actions bot commented Apr 3, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant