Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add New Outputs (EmulationStation + RetroDECK) #956

Merged
merged 17 commits into from
Feb 24, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Feb 24, 2024

Re-do of #943 because I think this GitHub Action wiped the branch: https://github.com/emmercm/igir/actions/workflows/gh-automerge-rebase.yml

@emmercm emmercm self-assigned this Feb 24, 2024
@emmercm emmercm enabled auto-merge (squash) February 24, 2024 03:54
Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/pr-943-again" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@maxexcloo
Copy link
Contributor

I'm very glad you have a backup because I don't LOL ❤️

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.35%. Comparing base (6d077c3) to head (ce338ec).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
+ Coverage   93.33%   93.35%   +0.01%     
==========================================
  Files          89       89              
  Lines        5554     5564      +10     
  Branches     1288     1290       +2     
==========================================
+ Hits         5184     5194      +10     
  Misses        352      352              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 186711c into main Feb 24, 2024
52 of 53 checks passed
@emmercm emmercm deleted the emmercm/pr-943-again branch February 24, 2024 04:17
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants