Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: dat-combine option #912

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Feature: dat-combine option #912

merged 6 commits into from
Feb 9, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Feb 4, 2024

RE: #754

@emmercm emmercm self-assigned this Feb 4, 2024
Copy link

github-actions bot commented Feb 4, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/dat-combiner" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm marked this pull request as ready for review February 9, 2024 00:50
@emmercm emmercm enabled auto-merge (squash) February 9, 2024 01:12
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a88e4cd) 93.39% compared to head (6886c19) 93.38%.

Files Patch % Lines
src/igir.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
- Coverage   93.39%   93.38%   -0.02%     
==========================================
  Files          87       88       +1     
  Lines        5390     5409      +19     
  Branches     1231     1235       +4     
==========================================
+ Hits         5034     5051      +17     
- Misses        338      340       +2     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit ea9df88 into main Feb 9, 2024
50 of 51 checks passed
@emmercm emmercm deleted the emmercm/dat-combiner branch February 9, 2024 01:26
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant