Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: catch CMPro DAT parsing errors #782

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Oct 22, 2023

Fixes: #781

@emmercm emmercm self-assigned this Oct 22, 2023
@emmercm emmercm enabled auto-merge (squash) October 22, 2023 23:50
@github-actions
Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/parse-dat-catch" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #782 (2a75534) into main (af710cc) will decrease coverage by 0.04%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
- Coverage   93.74%   93.71%   -0.04%     
==========================================
  Files          83       83              
  Lines        5035     5040       +5     
  Branches     1135     1137       +2     
==========================================
+ Hits         4720     4723       +3     
- Misses        298      300       +2     
  Partials       17       17              
Files Coverage Δ
src/modules/datScanner.ts 86.80% <85.71%> (-0.70%) ⬇️

@emmercm emmercm merged commit 5e44cb6 into main Oct 23, 2023
53 checks passed
@emmercm emmercm deleted the emmercm/parse-dat-catch branch October 23, 2023 00:06
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when processing certain libretro dats
1 participant