Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: breaking: exclude disks option #1260

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 30, 2024

No description provided.

@emmercm emmercm self-assigned this Jul 30, 2024
@emmercm emmercm enabled auto-merge (squash) July 30, 2024 00:48
@emmercm emmercm disabled auto-merge July 30, 2024 00:52
@emmercm emmercm changed the title Feature: include disks option Feature: exclude disks option Jul 30, 2024
@emmercm emmercm changed the title Feature: exclude disks option Feature: breaking: exclude disks option Jul 30, 2024
@emmercm emmercm enabled auto-merge (squash) July 30, 2024 01:50
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 12 lines in your changes missing coverage. Please review.

Project coverage is 93.22%. Comparing base (e63c5e8) to head (ca845e6).

Files Patch % Lines
src/modules/datScanner.ts 53.84% 6 Missing ⚠️
src/types/dats/dat.ts 69.23% 4 Missing ⚠️
src/modules/datMergerSplitter.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           emmercm/3.0.0-feature    #1260      +/-   ##
=========================================================
+ Coverage                  93.16%   93.22%   +0.05%     
=========================================================
  Files                        112      112              
  Lines                       7063     7124      +61     
  Branches                    1540     1569      +29     
=========================================================
+ Hits                        6580     6641      +61     
  Misses                       482      482              
  Partials                       1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit e16494d into emmercm/3.0.0-feature Jul 30, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/include-disks branch July 30, 2024 03:30
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/3.0.0-feature" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant