Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: consolidate file signature code #1225

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 20, 2024

No description provided.

@emmercm emmercm self-assigned this Jul 20, 2024
@emmercm emmercm enabled auto-merge (squash) July 20, 2024 20:22
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 98.71795% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.11%. Comparing base (3e10abf) to head (42092d2).

Files Patch % Lines
src/types/files/fileFactory.ts 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
+ Coverage   92.91%   93.11%   +0.20%     
==========================================
  Files         109      108       -1     
  Lines        6731     6695      -36     
  Branches     1585     1582       -3     
==========================================
- Hits         6254     6234      -20     
+ Misses        452      436      -16     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 5d738ef into main Jul 20, 2024
55 of 56 checks passed
@emmercm emmercm deleted the emmercm/consolidate-file-signatures branch July 20, 2024 20:28
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#main" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant