Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Famicom and Super Famicom output token matching #1044

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 25, 2024

Fixes: #1043

@emmercm emmercm self-assigned this Mar 25, 2024
@emmercm emmercm enabled auto-merge (squash) March 25, 2024 01:49
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.21%. Comparing base (a721494) to head (b109c11).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1044   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files          92       92           
  Lines        5969     5969           
  Branches     1430     1430           
=======================================
  Hits         5564     5564           
  Misses        384      384           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/famicom-tokens" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit 6ab8d34 into main Mar 25, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/famicom-tokens branch March 25, 2024 01:54
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add output token matching for "Famicom" and "Super Famicom"
1 participant