Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: prefer calculated CRC32 of archive entry contents #1021

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 20, 2024

No description provided.

@emmercm emmercm self-assigned this Mar 20, 2024
@emmercm emmercm enabled auto-merge (squash) March 20, 2024 23:34
Copy link

github-actions bot commented Mar 20, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/prefer-calculated-checksums" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.45%. Comparing base (caa51ae) to head (cdf9347).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1021   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files          91       91           
  Lines        5728     5728           
  Branches     1333     1333           
=======================================
  Hits         5353     5353           
  Misses        356      356           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit f016c87 into main Mar 21, 2024
52 of 53 checks passed
@emmercm emmercm deleted the emmercm/prefer-calculated-checksums branch March 21, 2024 00:20
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant