Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: centrally manage Node.js timeouts #1005

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 17, 2024

No description provided.

@emmercm emmercm self-assigned this Mar 17, 2024
@emmercm emmercm enabled auto-merge (squash) March 17, 2024 02:13
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 40.90909% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 93.04%. Comparing base (82eb81d) to head (5356e5f).

Files Patch % Lines
src/timer.ts 23.07% 10 Missing ⚠️
src/console/progressBarCli.ts 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
- Coverage   93.37%   93.04%   -0.33%     
==========================================
  Files          90       91       +1     
  Lines        5705     5724      +19     
  Branches     1329     1333       +4     
==========================================
- Hits         5327     5326       -1     
- Misses        360      378      +18     
- Partials       18       20       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 97bfeeb into main Mar 17, 2024
53 checks passed
@emmercm emmercm deleted the emmercm/centralized-timers branch March 17, 2024 02:18
Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/centralized-timers" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant